Use java.text.BreakIterator in DefaultTextDoubleClickStrategy#3990
Draft
vogella wants to merge 1 commit intoeclipse-platform:masterfrom
Draft
Use java.text.BreakIterator in DefaultTextDoubleClickStrategy#3990vogella wants to merge 1 commit intoeclipse-platform:masterfrom
vogella wants to merge 1 commit intoeclipse-platform:masterfrom
Conversation
Contributor
Replaces com.ibm.icu.text.BreakIterator with java.text.BreakIterator in DefaultTextDoubleClickStrategy and drops the matching Import-Package: com.ibm.icu.text from the bundle manifest. The JDK BreakIterator exposes the same API (getWordInstance, preceding, following, isBoundary, setText, DONE) and the existing POSIX-locale workaround for '.' not being treated as a word boundary continues to work with java.text. Removes the last com.ibm.icu reference from org.eclipse.jface.text.
Member
|
I'm looking forward to have icu entirely removed. |
Contributor
Author
|
I don't have a reference but the behavior is partially covered by unit tests which I extended. This was therefore not a drop in replacement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
com.ibm.icu.text.BreakIteratorwithjava.text.BreakIteratorinDefaultTextDoubleClickStrategyand drops the matchingImport-Package: com.ibm.icu.textfrom the bundle manifest. The JDKBreakIteratorexposes the same API (getWordInstance,preceding,following,isBoundary,setText,DONE) and the existing POSIX-locale workaround for.not being treated as a word boundary continues to work. This removes the lastcom.ibm.icureference fromorg.eclipse.jface.text.Planned for 4.41